Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document guards behavior when placed at controller and app level #3230

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

guacs
Copy link
Member

@guacs guacs commented Mar 20, 2024

Description

This PR documents the behavior of guards placed at the controller and app level being executed for OPTIONS requests.

I don't know if linking to the GitHub issue is the best way to go about this. I'm open to any ideas on how to document this behavior better.

Closes

This is related to #2314, but doesn't fix the underlying issue. Instead it documents the issue as well as provides a link to the issue where the users can find a workaround for it.

EDIT: Reword to make sure GitHub doesn't consider the linked issue as being fixed by this PR.

@guacs guacs requested review from a team as code owners March 20, 2024 10:59
@guacs guacs enabled auto-merge (squash) March 22, 2024 16:40
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@guacs guacs merged commit 5a9e9e9 into main Mar 22, 2024
20 checks passed
@guacs guacs deleted the document-guards-limitation branch March 22, 2024 16:45
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants