fix: add create_engine() method to SQLAlchemy configs.
#2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
requested review from
a team,
JacobCoffee and
provinzkraut
as code owners
guacs
approved these changes
Sep 29, 2023
provinzkraut
approved these changes
Sep 29, 2023
This PR fixes a break in backward compatibility where the `create_engine()` method was removed from the SQLAlchemy config types in a minor version increment.
provinzkraut
force-pushed
the
sqla-conf-create-engine
branch
from
bcc791f to
3d1b551
Compare
cofin
approved these changes
Sep 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a break in backward compatibility where the
create_engine()method was removed from the SQLAlchemy config types in a minor version increment.Pull Request Checklist
Description
Close Issue(s)