feat(sqlalchemy): extend SQLAlchemy Plugin to include Alembic #2164
Conversation
Ensure deterministic handler order
* Support custom status code for openapi exceptions * add docs for custom exceptions in OpenAPI schemas --------- Co-authored-by: Na'aman Hirschfeld <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2164 |
…star into sqlalchemy-alembic-cli
… SQLAlchemyInitPlugin
| If neither plugin is found, it raises an ImproperlyConfiguredException. | ||
| """ | ||
| for type_ in SQLAlchemyPlugin, SQLAlchemyInitPlugin: | ||
| with suppress(KeyError): |
There was a problem hiding this comment.
| with suppress(KeyError): | |
| if type_ in app.plugins: |
There was a problem hiding this comment.
Thinking if we should maybe add a different method to retrieve a plugin that might not exist / add a default of None to this one?
There was a problem hiding this comment.
Suggested change
with suppress(KeyError):
if type_ in app.plugins:
I think this does not exactly do what I intend to? It always seems to trigger ImproperlyConfiguredException
Co-authored-by: Janek Nouvertné <[email protected]>
This reverts commit 4357326.
|
In commit cffc81b, the addition of |
|
Is there any reason why this was closed and the branch deleted? It appears a significant amount of work was put into this and it was just about done unless I'm misunderstanding something here. |
|
@Faolain - cofin stepped down as maintainer. You can see the discussion in our discord server. I restored the branch for now. |
Pull Request Checklist
Description
Close Issue(s)