Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Commit

Permalink
Add upper bound for Rack so Lita will still work with Ruby < 2.2.
Browse files Browse the repository at this point in the history
  • Loading branch information
@jimmycuadra
jimmycuadra committed Jul 22, 2016
1 parent c3ae7d0 commit fda3a80
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lita.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency "i18n", ">= 0.6.9"
spec.add_runtime_dependency "lita-default-handlers"
spec.add_runtime_dependency "puma", ">= 2.7.1"
spec.add_runtime_dependency "rack", ">= 1.5.2"
spec.add_runtime_dependency "rack", ">= 1.5.2", "< 2.0.0"
spec.add_runtime_dependency "rb-readline", ">= 0.5.1"
spec.add_runtime_dependency "redis-namespace", ">= 1.3.0"
spec.add_runtime_dependency "thor", ">= 0.18.1"
Expand Down

2 comments on commit fda3a80

@harigopal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmycuadra Is this limitation truly necessary? I've just had to fork lita to get it to work with Rails 5 (because its actionpack requires rack ~> 2.0). Wouldn't leaving the upper-bound out cause whoever is installing the gem to use a lower version of rack (since rack > 2 specifies s.required_ruby_version = '>= 2.2.2')?

@jimmycuadra
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems to be necessary. Rack > 2 specifying a newer version of Ruby did not seem to prevent it from being installed on older Ruby versions.

Please sign in to comment.