Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running as part of the test suite so we can prove it works off a mainnet fork.
Random Maker vault chosen for migration: 24225 - see https://defiexplore.com/cdp/24225
Vault
ID: 24225
Collateral: 45.74 ETH
Debt: 26,728 DAI
Execution steps
The recipe fails when repaying the DAI debt due to having "dust" leftover in the vault debt (it should be 0). There are two values for the vault debt given back from the Maker Resolver:
vault.debt = 28150.579662849398312088
and
vault.art = 26728.972153870455837076
From Maker glossary:
When we repay using
vault.debt
as the amount, we get the following error:Error: VM Exception while processing transaction: reverted with reason string 'paying-excess-debt'
When we repay using
vault.art
as the amount, we get the following error:Error: VM Exception while processing transaction: reverted with reason string 'Vat/dust'
So the available values either repay too much or not enough.