Jd 2023 10 search result title #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2023-10-search-result-title
branch
from
f99a54b to
ac18b9d
Compare
goapunk
force-pushed
the
jd-2023-10-search-result-title
branch
from
ac18b9d to
80eed48
Compare
philli-m
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Looking good and it works but when I try to change the language when I am on the search results page I get the following error
RequestError(400, 'x_content_parse_exception', '[multi_match] unknown token [VALUE_NULL] after [query]')
NOTE: on dev this action triggers a 500 error so pre existing problem
goapunk
changed the title
goapunk
force-pushed
the
jd-2023-10-search-result-title
branch
2 times, most recently
from
278e145 to
f587025
Compare
* add some missing fields to index * remove no longer needed ElasticSearchCustomQueryCompiler
goapunk
force-pushed
the
jd-2023-10-search-result-title
branch
from
f587025 to
99092fe
Compare
goapunk
changed the title
|
@m4ra @philli-m I also added the elasticsearch update. Once this is merged we also need to merge https://github.com/liqd/admin/pull/651/files |
philli-m
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes various issues with the search