django upgrade 4.0

liqd · Oct 31, 2023 · d3681b6 · d3681b6
1 parent a29990b
commit d3681b6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/changelog/7782.md b/changelog/7782.md
@@ -0,0 +1,7 @@
+### Updated
+
+    - Django from 3.2.19 to 4.0 
+      - apps: remove deprecated app config in apps init 
+      - settings: LN10N is now enabled by default
+      - templates: ifequal not supported 
+
diff --git a/digitalstrategie/settings/base.py b/digitalstrategie/settings/base.py
@@ -118,8 +118,6 @@
 
 USE_I18N = True
 
-USE_L10N = True
-
 USE_TZ = True
 
 LANGUAGES = [

diff --git a/digitalstrategie/templates/includes/pagination.html b/digitalstrategie/templates/includes/pagination.html
@@ -17,7 +17,7 @@
 
         {% for page_number in paginated_page_range %}
             {% if page_number >= 0 %}
-            <li {% ifequal page_number page_obj.number %}class="active" aria-current="page"{% endifequal %}>
+            <li {% if page_number == page_obj.number %}class="active" aria-current="page"{% endif %}>
                 {% combined_url_parameter request.GET page=page_number as url_par %}
                 <a href="{{ url_par }}{% if anchor %}{{ anchor }}{% endif %}">{{ page_number }}</a>
             </li>

diff --git a/digitalstrategie/templates/includes/upper_footer.html b/digitalstrategie/templates/includes/upper_footer.html
@@ -22,7 +22,8 @@ <h3 class="heading js-trigger">{{ menuitem.title }}</h3>
                                 {% get_language_info for 'de-ls' as language %}
                                 {% get_has_translation page 'de_ls' as has_translation_de_ls %}
                                 <li>
-                                    <form class="footer-menu__btn" action="{% url 'set_language' %}" method="post">
+					<!-- following might not working bcz of django 4.0 doesn’t set the user language in request.session--> 
+                                    <form class="footer-menu__btn" action="{% url 'set_language' %}" method="post"
                                         {% csrf_token %}
                                         <input name="next" type="hidden" value="{% if has_translation_de_ls %}{{ redirect_to }}{% else %}/{% endif %}" />
                                         <input name="language" type="hidden" value="{{ language.code }}">

diff --git a/requirements/base.txt b/requirements/base.txt
@@ -1,5 +1,5 @@
 brotli==1.1.0
-Django==3.2.19
+Django==4.0
 django-cloudflare-push==0.2.2
 django-csp==3.7
 django-multiselectfield==0.1.12