apps/measures: use url field not charfield for website fixes #878

apps/measures/migrations/0012_use_urlfield_for_website.py

@@ -0,0 +1,28 @@
+# Generated by Django 3.2.19 on 2023-10-26 14:57
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('apps_measures', '0011_alter_measuresdetailpage_districts'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='measuresdetailpage',
+            name='contact_website_de',
+            field=models.URLField(blank=True, max_length=2000),
+        ),
+        migrations.AlterField(
+            model_name='measuresdetailpage',
+            name='contact_website_de_ls',
+            field=models.URLField(blank=True, max_length=2000),
+        ),
+        migrations.AlterField(
+            model_name='measuresdetailpage',
+            name='contact_website_en',
+            field=models.URLField(blank=True, max_length=2000),
+        ),
+    ]

apps/measures/models.py

@@ -461,15 +461,15 @@ class MeasuresDetailPage(TranslatedMetadataPageMixin, Page):
     contact_phone = models.CharField(max_length=20, blank=True)
 
     contact_organisation_name_de = models.CharField(max_length=80, blank=False)
-    contact_website_de = models.CharField(max_length=2000, blank=True)
+    contact_website_de = models.URLField(max_length=2000, blank=True)
 
     contact_organisation_name_en = models.CharField(max_length=80, blank=True)
-    contact_website_en = models.CharField(max_length=2000, blank=True)
+    contact_website_en = models.URLField(max_length=2000, blank=True)
 
     contact_organisation_name_de_ls = models.CharField(
         max_length=80, blank=True
     )
-    contact_website_de_ls = models.CharField(max_length=2000, blank=True)
+    contact_website_de_ls = models.URLField(max_length=2000, blank=True)
 
     page_title = TranslatedField(
         'page_title_de',

apps/measures/templates/apps_measures/measures_detail_page.html

@@ -112,7 +112,7 @@ <h2 class="title">{% translate 'Contact' %}</h2>
                 <li class="tel"><a href="tel:{{page.contact_phone}}">{{ page.contact_phone }}</a></li>
             {% endif %}
             {% if page.contact_website %}
-                <li class="homepage"><a href="{{page.contact_website}}">{{ page.contact_website }}</a></li>
+                <li class="homepage"><a href="{{page.contact_website}}" target="_blank">{{ page.contact_website }}</a></li>
             {% endif %}
         </ul>
     </section>

changelog/878.md

@@ -0,0 +1,3 @@
+### Changed
+
+- changed CharField to URLField for measure detail website to ensure links works fixes 878