-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7601] Install and configure Celery #2523
Conversation
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 30a6e10 |
cf9061e
to
5b8ee85
Compare
5b8ee85
to
3714b34
Compare
4cd21c8
to
ab3d95a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
just few tiny corrections
30a6e10
to
3a7e328
Compare
9c98260
to
341bd17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background task need the migration to zero as we discussed, then we can remove them from settings + requirements
a34a8a4
to
80f4d5b
Compare
80f4d5b
to
a5805f8
Compare
b735cc7
to
2907d0e
Compare
abf24cb
to
47ca74b
Compare
I have added a new celery configuration parameter:
that instructs celery to save more information in the results backend. So what used to be:
is now
|
47ca74b
to
e5dc7a8
Compare
As discussed with goapunk, I have added
|
e5dc7a8
to
07add1a
Compare
07add1a
to
6980b13
Compare
6980b13
to
eb7ab6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to merge once we merge a4 PR and update the requirements here
eb7ab6d
to
10c2617
Compare
I have replaced the last version bump commit with one that imports the latest a4, namely db03f3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! Will leave for @m4ra to give final review and merge
No description provided.