-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8450] update django-allauth #5779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if socialaccount is not used, then lets remove it also from the settings INSTALLED_APPS.
There is also a change on how the user is logged in after clicking the link
Verifying the email address by clicking on the link would no longer log you in, even in case of ACCOUNT_LOGIN_ON_EMAIL_CONFIRMATION = True.
from changelog. Good to add this in the changelog maybe? We need to inform also PM?
yes, good point!
To me this reads like a bugfix, they fixed that |
cb724b0
to
427e39f
Compare
@m4ra I tested the behaviour on stage against this PR and for both you get automatically logged in when verifying your email, so I think we missed the version of allauth where it broke :) |
@goapunk I tested already on stage, and logs you in after verifying email. So should be fine |
ah, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@m4ra hmm, now the tests are failing :/ maybe I leave the social account stuff in for now ? We usually have the policy to remove unused code but also this might be out of scope for the release story |
427e39f
to
f184f71
Compare
Leave it out yes. Maybe create an gh issue |
created #5828 |
Describe your changes
Update django-allauth to latest version and adapt to changes. Remove the unused social settings and forms.
Tasks