Add more granular "Advanced" filtering #13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've added a set of ENV variables derived directly from the latest Docker API and matching files for filtering using them.
The
ADVANCED
env variable selects for the new files which use the new variables.Issues that I see with this current solution:
Benefits of this PR and context:
Should close #12 and should tighten up the security of the proxy which currently allows more commands through than probably intended.
How Has This Been Tested?
I did some rough testing by launching a compose with a container built on this change and one that operated as a console.
I then manually sent some
curl
commands through to try and access a couple allowed and disallowed options.This was not as thorough as I'd like and should be double checked before merging.
Source / References: