Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to 3.18 #52

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Rebase to 3.18 #52

merged 7 commits into from
Dec 8, 2023

Conversation

thespad
Copy link
Member

@thespad thespad commented Jul 12, 2023

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team July 12, 2023 12:33
@thespad thespad self-assigned this Jul 12, 2023
@thespad
Copy link
Member Author

thespad commented Jul 12, 2023

@KingBBQ this should be a very straightforward change, but would appreciate you giving it a once-over when the PR build is complete.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.7.0-pkg-03e8c321-dev-26812c54fc645267bed5ec8c2390dcae52b3e62a-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.7.0-pkg-03e8c321-dev-26812c54fc645267bed5ec8c2390dcae52b3e62a-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.7.0-pkg-03e8c321-dev-26812c54fc645267bed5ec8c2390dcae52b3e62a-pr-52 ✅
arm64v8-5.7.0-pkg-03e8c321-dev-26812c54fc645267bed5ec8c2390dcae52b3e62a-pr-52 ✅

@thespad
Copy link
Member Author

thespad commented Aug 10, 2023

Won't build at the moment ecause irrlicht committed minetest/irrlicht@c40045a and released against it, and while minetest has committed minetest/minetest@6bf63d4 there's no release with it so the build fails.

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@thespad thespad added awaiting-approval Stale exempt and removed no-pr-activity labels Sep 10, 2023
@thespad
Copy link
Member Author

thespad commented Dec 7, 2023

Upstream released 5.8.0 so this should now build

@thespad
Copy link
Member Author

thespad commented Dec 7, 2023

Ugh, no 5.8.0 tagged release for https://github.com/minetest/minetest_game so the build is failing

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-2b8fa27949358392047fc7536d10b3eda84cf22b-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-2b8fa27949358392047fc7536d10b3eda84cf22b-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-2b8fa27949358392047fc7536d10b3eda84cf22b-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-2b8fa27949358392047fc7536d10b3eda84cf22b-pr-52 ✅

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-bc06ef9077593d9577186cea6f19481dacbc5ff2-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-bc06ef9077593d9577186cea6f19481dacbc5ff2-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-bc06ef9077593d9577186cea6f19481dacbc5ff2-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-bc06ef9077593d9577186cea6f19481dacbc5ff2-pr-52 ✅

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-18a86221cb16146bf0c0b6c5b7931aab7d989179-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-18a86221cb16146bf0c0b6c5b7931aab7d989179-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-18a86221cb16146bf0c0b6c5b7931aab7d989179-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-18a86221cb16146bf0c0b6c5b7931aab7d989179-pr-52 ✅

zJudGenie
zJudGenie reviewed Dec 7, 2023
View reviewed changes
Copy link

@zJudGenie zJudGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing typo, also why the gameid is set to devtest ? Just to test it ?

Jenkinsfile Outdated Show resolved Hide resolved
jenkins-vars.yml Outdated Show resolved Hide resolved
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-715c8641c388e9a71db0c5115dbd04e3094901e2-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-715c8641c388e9a71db0c5115dbd04e3094901e2-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-715c8641c388e9a71db0c5115dbd04e3094901e2-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-715c8641c388e9a71db0c5115dbd04e3094901e2-pr-52 ✅

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-cf0d8c78888ff19bbf552d2d7e8bcbd94f294c95-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-cf0d8c78888ff19bbf552d2d7e8bcbd94f294c95-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-cf0d8c78888ff19bbf552d2d7e8bcbd94f294c95-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-cf0d8c78888ff19bbf552d2d7e8bcbd94f294c95-pr-52 ✅

@thelamer thelamer mentioned this pull request Dec 8, 2023
Closed
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-1ace484fac1dc2d169ac6419c9b6472dbb8a911c-pr-52/index.html
https://ci-tests.linuxserver.io/lspipepr/minetest/5.8.0-pkg-e3d5d368-dev-1ace484fac1dc2d169ac6419c9b6472dbb8a911c-pr-52/shellcheck-result.xml

Tag Passed
amd64-5.8.0-pkg-e3d5d368-dev-1ace484fac1dc2d169ac6419c9b6472dbb8a911c-pr-52 ✅
arm64v8-5.8.0-pkg-e3d5d368-dev-1ace484fac1dc2d169ac6419c9b6472dbb8a911c-pr-52 ✅

@aptalca aptalca merged commit 12db3f5 into master Dec 8, 2023
3 checks passed
@aptalca aptalca deleted the 3.18 branch December 8, 2023 01:23
@aptalca aptalca mentioned this pull request Dec 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zJudGenie zJudGenie zJudGenie left review comments

@aptalca aptalca aptalca approved these changes

Assignees

@thespad thespad

Labels
awaiting-approval Stale exempt
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thespad @LinuxServer-CI @aptalca @zJudGenie