fs_watcher:修复跟踪write系统调用时的错误 #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxmzy88
requested review from
13186379707,
helight,
LinkinPF and
chenamy2017
as code owners
|
可以增加一下相关的测试用例 |
是说要增加单元测试吗？对单元测试有什么要求？使用什么框架呢？ |
可以参考一下 cpu 的，这里没有框架要求 |
两个write.bpf.c，一个在fs_watcher目录下，一个在fs_watcher/bpf下，有什么区别？是不是要去掉一个？ |
这个你看看代码，和你们小组的同学讨论一下，看是不是可以删除或者合并 |
|
不是，这个目录底下的这个old_project里面的writeebpf程序才是对的，相关的正确的程序已经移动到这个MagicEyes里面开发了 |
好的，那麻烦删除一下废弃的代码吧，要不造成困扰呢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对do_sys_openat2跟踪时，struct fs_t *e定义了未分配空间，后续使用会出现崩溃；fd未更新到map。
对vfs_write跟踪时，没有提交结果。
针对以上两个问题进行修复。