Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

尝试重新提交 #506

Merged
merged 24 commits into from
Sep 25, 2023
Merged

尝试重新提交 #506

merged 24 commits into from
Sep 25, 2023

Conversation

13186379707
Copy link
Contributor

@13186379707 13186379707 commented Aug 30, 2023

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@helight
Copy link
Member

helight commented Aug 31, 2023

自动流水线没有创建,这块要加一下
是我们自己的代码记上我们的文件头

// Copyright 2023 The LMP Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://github.com/linuxkerneltravel/lmp/blob/develop/LICENSE
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// author: [email protected]
//
// 文件功能说明,说明该文件的用途和目的


以上是我们的代码注释头,大家顺手都加上

@@ -732,4 +732,4 @@ int main(int argc, char *argv[])
#endif
Copy link
Member

@helight helight Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、给这个文件加一个 makefile,
2、加一个 github 的action流水线,可以自动化编译。
3、让这个fusedemo 可以在 ubuntu22.4 以上的系统上可以跑。

ldconfig
gcc fusedemo.c -o fusedemo `pkg-config fuse3 --cflags --libs`
```
## 运行(挂载):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个放到 fusedemo 的 readme 中?

@chenamy2017
Copy link
Contributor

在issuse里面创建tasklist,和pr关联起来再提交。

@13186379707
Copy link
Contributor Author

师兄好,由于该项目是在ubuntu16.04上进行开发,因此无法在ubuntu22.04版本上进行正常复现和测试,并且该项目的开发过程中并未用到bcc等工具,只修改了内核代码,所以没有加相关的编译测试

### 将fuse加入pkg环境变量后用gcc编译:(填入你自己的fuse3.pc地址)

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 demo 可以在 2204 上跑吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个demo是可以的,但是剩下的有部分代码应该是跑不了的

@helight helight merged commit a7599e1 into linuxkerneltravel:develop Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants