oem-factory-reset: remove duplicates and add proper error redirection to file #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tlaurion
commented
Mar 28, 2023
tlaurion
commented
- Trace calls need to happen after sourcing /etc/functions not before
- Move sourcing of external files at beginning of file, remove /etc/functions sourcing duplicate
- gpg error redirection was sent to /dev/null where expected to be added to whiptail in case of error (2>&1 instead and redirection to file)
|
@danielp96 if you see this and can test this would be nice, pretty trivial changes but still bugfixes |
|
@tlaurion Tested OEM factory reset on a Librem 14, everything working fine. |
|
@danielp96 Purely esthetic. Useful only when trying to bump gpg toolstack and when gpg screenscraping fails, to see gpg error trace which is expected to be under file, taken as input from whiptail to show on screen, helping us finding discrepencies from comand line input and from fd (yes: those are different....) Rebasing on master with @ThePlexus fix #1357 and merging |
… to file - Trace calls need to happen after sourcing /etc/functions not before - Move sourcing of external files at beginning of file, remove /etc/functions sourcing duplicate - gpg error redirection was sent to /dev/null where expected to be added to whiptail in case of error (2>&1 instead and redirection to file)
tlaurion
force-pushed
the
oem-factory-reset_clean
branch
from
0ff323a to
65b81e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.