Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip fingerprint if fstab is not written #496

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Dec 11, 2024

Some tests do not cause the role to touch /etc/fstab, so skip the
fingerprint check.

Signed-off-by: Rich Megginson [email protected]

Some tests do not cause the role to touch /etc/fstab, so skip the
fingerprint check.

Signed-off-by: Rich Megginson <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.73%. Comparing base (59fd1c6) to head (acabc5a).
Report is 18 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (acabc5a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (acabc5a)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   16.54%   10.73%   -5.81%     
==========================================
  Files           2        8       +6     
  Lines         284     1946    +1662     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1737    +1500     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm
Copy link
Contributor Author

richm commented Dec 11, 2024

[citest]

@richm richm merged commit 44216b9 into linux-system-roles:main Dec 11, 2024
23 of 26 checks passed
@richm richm deleted the test-fingerprint-errors branch December 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant