Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VDO tests and packages fixes for Fedora and RHEL 10 #490

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

vojtechtrefny
Copy link
Collaborator

The VDO kernel module is now part of upstream kernel and renamed from kvdo to dm-vdo. The vdo package with userspace tools is now available on RHEL/CentOS 10 and Fedora in standard repositories, no need to enable the Copr repository.

@vojtechtrefny vojtechtrefny changed the title VDO tests and packages fixes for Fedora and RHEL 10 fix: VDO tests and packages fixes for Fedora and RHEL 10 Nov 20, 2024
@vojtechtrefny
Copy link
Collaborator Author

The python 2.7 test failure seems to be a Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/2089071

@richm
Copy link
Contributor

richm commented Nov 20, 2024

[citest]

@richm
Copy link
Contributor

richm commented Nov 20, 2024

looks like the check for vdo isn't working, or additional packages need to be installed

VDO is now available in Fedora and the kernel module (now named
"dm-vdo" instead of "kvdo") is now part of the upstream kernel.
The "vdo" package is now available on all supported versions of
Fedora in the base repository.
The package with VDO userspace tools is now available.
@vojtechtrefny
Copy link
Collaborator Author

[citest]

@vojtechtrefny
Copy link
Collaborator Author

looks like the check for vdo isn't working, or additional packages need to be installed

I needed to backport one patch to libblockdev on Fedora 40 (the build will take few days to go through Bodhi). And I also didn't realize that skipped tasks will still register as success so the checks for the kernel module presence were not working correctly.

@vojtechtrefny
Copy link
Collaborator Author

[citest]

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.73%. Comparing base (59fd1c6) to head (b78243e).
Report is 14 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (b78243e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (b78243e)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   16.54%   10.73%   -5.81%     
==========================================
  Files           2        8       +6     
  Lines         284     1946    +1662     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1737    +1500     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vojtechtrefny
Copy link
Collaborator Author

libblockdev 3.1.1-2 is now available in Fedora 40 (Fedora 39 is EOL so the update won't be included there) and the VDO tests are passing.

@vojtechtrefny vojtechtrefny requested a review from richm November 30, 2024 07:51
@richm richm merged commit 6ecf7ac into linux-system-roles:main Dec 2, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants