Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use blkid instead of lsblk in tests to get partition table #480

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

vojtechtrefny
Copy link
Collaborator

Older versions of lsblk cannot print the PTTYPE column.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.73%. Comparing base (59fd1c6) to head (024212b).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (024212b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (024212b)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   16.54%   10.73%   -5.81%     
==========================================
  Files           2        8       +6     
  Lines         284     1946    +1662     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1737    +1500     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spetrosi
Copy link
Contributor

[citest]

Older versions of lsblk cannot print the PTTYPE column.
@vojtechtrefny vojtechtrefny force-pushed the main_pttype-check-fix branch from 88c9d20 to 024212b Compare August 27, 2024 13:43
@vojtechtrefny
Copy link
Collaborator Author

[citest]

@richm
Copy link
Contributor

richm commented Aug 27, 2024

Works locally with: ansible 2.9/centos-7, ansible 2.16/centos-8, ansible 2.17/centos-10

@richm
Copy link
Contributor

richm commented Aug 27, 2024

The stratis failure on el8 is known and will be fixed in a subsequent PR

@richm richm merged commit 762cda3 into linux-system-roles:main Aug 27, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants