fix: Fix 'possibly-used-before-assignment' pylint issues #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 16.54% 11.65% -4.90%
==========================================
Files 2 8 +6
Lines 284 1785 +1501
Branches 79 0 -79
==========================================
+ Hits 47 208 +161
- Misses 237 1577 +1340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vojtechtrefny
force-pushed
the
main_pylint-fixes
branch
4 times, most recently
from
eafe208 to
6cfc3a5
Compare
Latest pylint added a new check for values used before assignment. This fixes these issues found in the blivet module. Some of these are false positives, some real potential issues.
vojtechtrefny
force-pushed
the
main_pylint-fixes
branch
from
6cfc3a5 to
967748e
Compare
Merged
|
@vojtechtrefny lgtm - ready to merge? |
richm
approved these changes
May 29, 2024
vojtechtrefny
merged commit bfaae50
into
linux-system-roles:main
17 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest pylint added a new check for values used before assignment. This fixes these issues found in the blivet module. Some of these are false positives, some real potential issues.