Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crmsh watchdog correction, remove obsolete assert for softdog #217

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

marcelmamula
Copy link
Contributor

Enhancement:

  • Remove obsolete assert for softdog, which was not working
  • Add default softdog, to avoid issue when /dev/watchdog is not present causing SBD service to fail.

Reason:

Result:

  • Tested and verified on SLES4SAP 15.

Issue Tracker Tickets (Jira or BZ if any):

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (b0f0f96) to head (06093e4).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          124      124           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek tomjelinek merged commit 06093e4 into linux-system-roles:main Jul 30, 2024
21 checks passed
@marcelmamula marcelmamula deleted the sbd branch October 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants