Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel: enable intel-nvme.c build without json-c dependencies checking #2633

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ikegami-t
Copy link
Contributor

Only build json print codes with CONFIG_JSONC build option instead.

Only build json print codes with CONFIG_JSONC build option instead.

Signed-off-by: Tokunori Ikegami <[email protected]>
@igaw igaw merged commit b368e36 into linux-nvme:master Dec 20, 2024
16 checks passed
@igaw
Copy link
Collaborator

igaw commented Dec 20, 2024

Thanks!

@HaroPanosyan
Copy link
Contributor

Intel sold it's SSD business 3 years ago to SK Hynix and they started a new company called Solidigm which I work for. We have Solidigm plugin and our plan is to eventually deprecate Intel plugin. We are thinking of having warning message so anyone using Intel plugin to consider start using Solidigm plugin.
Any help/suggestion how we can properly do this would be very nice. Thanks.

@ikegami-t
Copy link
Contributor Author

ikegami-t commented Dec 20, 2024

At first seems better create an issue also for the @HaroPanosyan mention since the PR already merged. Sorry I am not sure about that but seems good to delete the plugin on newer version nvme-cli and then mentioed it by the release note cleary. (By the way for example the toshiba plugin looks as long time not maintained. Also Toshiba SSD business separated from Toshiba to Toshiba memory before then now change changed the company name also to Kioxia. So seems the plugin also can be deleted.)

@HaroPanosyan
Copy link
Contributor

Thanks. There could be still some users, so I was thinking instead of deleting, allow some time by just showing "soon to be deprecated, instead use Solidigm plugin" message or something like that.

@ikegami-t
Copy link
Contributor Author

Okay I see. By the way the intel plugin is older but the newer version solidigm plugin will support the same command feature. Is this really correct? Or is the command specification basically same for the old features on both intel and solidgm SSDs?

@HaroPanosyan
Copy link
Contributor

Correct, we already should cover everything intel plugin does and more. We have newer drives with newer Vendor Unique (VU) logs/features and we plan Solidigm plugin to be where everything goes and eventually deprecate/delete Intel plugin.

@ikegami-t
Copy link
Contributor Author

Noted. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants