Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme-id-domain(1): dom{ia => ai}n #2551

Closed
wants to merge 1 commit into from

Conversation

nabijaczleweli
Copy link
Contributor

$ sed -i 's/domian/domain/g' $(git grep -l domian)

@igaw
Copy link
Collaborator

igaw commented Oct 29, 2024

Looks good. Could you just update the *.txt file, the other ones are generated/updated on release. We ship the autogenerated ones, because some distros want to avoid having another build dependency added for nvme-cli (the doc tool chain which is unfortunatly pretty large).

$ sed -i 's/domian/domain/g' $(git grep -l domian)

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
Copy link
Contributor Author

applied

@igaw
Copy link
Collaborator

igaw commented Oct 30, 2024

I've applied the patch directly after adding a prefix to subject title. Thanks!

@igaw igaw closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants