Fixes for the print code refactoring #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NQN' Unfortunately, blktests nvme/003 depends on this feature. To avoid any regression in the testsuite revert the change. After this has been address in blktests we can add it back. Fixes: 9077d04 ("fabrics: prevent 'nvme connect' to well-known discovery NQN") Signed-off-by: Daniel Wagner <[email protected]>
During the print code refactoring, the show connect message was enabled per default. To avoid any regressions in application restore the old behavior and print only the result when the '-o' option is used. Fixes: 0576d84 ("fabrics: Move printing functions to the print files") Signed-off-by: Daniel Wagner <[email protected]>
Use validate_output_format instead open coding the print flag parsing. Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes due to the recent code refactoring.
It also includes the revert for #1976