types: Live Migration #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
NateThornton
force-pushed
the
lm_types
branch
3 times, most recently
from
300f72e to
4a2effd
Compare
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
igaw
reviewed
Nov 29, 2024
|
Comments reviewed - thanks for detailed scrutiny. I hope to have the changes ready by end of week. Will resolve with #916 too. |
|
Thanks a lot. Yeah, I went down the rabbit hole :) |
NateThornton
force-pushed
the
lm_types
branch
3 times, most recently
from
f2da12d to
0aedaba
Compare
Continues efforts from the newly minted TP4159 PCIe Infrastructure for Live Migration specification by adding additional types. Signed-off-by: Nate Thornton <[email protected]>
|
Sorry for the late response... (insert my usual busy excuse...) |
NateThornton
force-pushed
the
lm_types
branch
2 times, most recently
from
53d7cef to
3c2aeaf
Compare
|
Incorporated all feedback & tidied up a few items. Hopefully this is it 🤞 |
|
Looks good. Sorry that I enforce these rules on the API. I am more relaxed when it comes to the implementation but APIs tend to be PITA if we get them wrong (e.g. see the struct args stuff... something for 2.0) Anyway, thanks for the patience. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues efforts from the newly minted TP4159 PCIe Infrastructure for Live Migration specification by adding additional types.