Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Request or Response Length in DLEN and DOFF for MI #897

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Use Request or Response Length in DLEN and DOFF for MI #897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/nvme/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ int nvme_mi_admin_xfer(nvme_mi_ctrl_t ctrl,
{
struct nvme_mi_resp resp;
struct nvme_mi_req req;
__u32 dlen, doff;
int rc;

/* length/offset checks. The common _submit() API will do further
Expand Down Expand Up @@ -692,8 +693,17 @@ int nvme_mi_admin_xfer(nvme_mi_ctrl_t ctrl,

/* limit the response size, specify offset */
admin_req->flags = 0x3;
admin_req->dlen = cpu_to_le32(resp.data_len & 0xffffffff);
admin_req->doff = cpu_to_le32(resp_data_offset & 0xffffffff);

/* dlen and doff have different interpretations depending on the data direction */
if (req_data_size) {
dlen = req_data_size & 0xffffffff;
doff = 0;
} else {
dlen = *resp_data_size & 0xffffffff;
doff = resp_data_offset & 0xffffffff;
}
admin_req->dlen = cpu_to_le32(dlen);
admin_req->doff = cpu_to_le32(doff);

rc = nvme_mi_submit(ctrl->ep, &req, &resp);
if (rc)
Expand Down