types: Fix NVME_CSTS_SHST_MASK definition #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Apr 2, 2024
src/nvme/types.h
Outdated
| NVME_CSTS_NSSRO_MASK = 0x1, | ||
| NVME_CSTS_PP_MASK = 0x1, | ||
| NVME_CSTS_SHST_NORMAL = 0, | ||
| NVME_CSTS_SHST_OCCUR = 1, | ||
| NVME_CSTS_SHST_CMPLT = 2, | ||
| NVME_CSTS_SHST_MASK = 3, | ||
| NVME_CSTS_SHS_MASK = NVME_CSTS_SHST_MASK, /* Deprecated */ |
There was a problem hiding this comment.
I think there is a typo, shouldn't it be NVME_CSTS_SHN_MASK?
There was a problem hiding this comment.
Sorry for the error. Right just fixed as mentioned.
Deprecate NVME_CSTS_SHN_MASK instead. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
csts-shst-mask
branch
from
8e84f08 to
d7dc3c1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate NVME_CSTS_SHS_MASK instead.