Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: Add nvme_root identify flag to scan NVMe topology #790

Closed
wants to merge 1 commit into from

Conversation

ikegami-t
Copy link
Contributor

This is to avoid nvme identify namespace to scan NVMe topology.

This is to avoid nvme identify namespace to scan NVMe topology.

Signed-off-by: Tokunori Ikegami <[email protected]>
@ikegami-t
Copy link
Contributor Author

The nvme identify namespace done by the sysfs ns nuse ns_head_update_nuse() and ns_update_nuse() as below.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvme/host/sysfs.c#n201

@igaw
Copy link
Collaborator

igaw commented Mar 18, 2024

The nvme identify namespace done by the sysfs ns nuse ns_head_update_nuse() and ns_update_nuse() as below. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvme/host/sysfs.c#n201

This should have been in the commit message explaining why the change is needed. This is important for anyone later to figure out why we added a change.

@ikegami-t
Copy link
Contributor Author

Okay will update the commit message later.

@igaw
Copy link
Collaborator

igaw commented Mar 19, 2024

I am still pondering how to address this. The change is quite big in order to pass down a simple flag. I wonder if some sort of refactoring is necessary first.

@hreinecke
Copy link
Collaborator

Instead of passing flags we should drop the call to 'nvme_scan()' and use the device name directly. Much like we already do for eg 'nvme reset'.

@igaw
Copy link
Collaborator

igaw commented Mar 19, 2024

We don't need this anymore, fixed it differently: linux-nvme/nvme-cli@a31081a

@igaw igaw closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants