NBFT parser SSNS flags #781
Conversation
|
This is pretty much work in progress and we might need some more flags. nvme-cli patches will follow. The most important question: is the addition of new struct members at the end of structs okay with you? |
|
Hmm, as long we can figure out that we don't break existing users, you can do whatever is needed. That means older binary version of nvme-cli should still work against newer libnvme versions. If I get this right, this should work if you extend at the end of the struct. The other dependency order should be handled in nvme-cli. Which I think we do with the version check. |
|
Thanks, I'm not aware of any user other than nvme-cli. Potentially network management daemons (NetworkManager, wicked) may need to parse some extra info, but I'm not aware of such thing happening at the moment. We do plan to further extend these convenient |
|
Yes this code is pretty fresh so I am not really concerned about breaking stuff. Maybe we should mark certain features as experimental until we are happy with it. Just as idea. |
tbzatek
force-pushed
the
nbft-flags-1
branch
3 times, most recently
from
3f382c4 to
445699c
Compare
Added an explicit note about unstable API, that is in fact semi-unstable whereas existing structures are stable and new API will possibly be added at the end of the structs. Signed-off-by: Tomas Bzatek <[email protected]>
tbzatek
force-pushed
the
nbft-flags-1
branch
2 times, most recently
from
b4f7c28 to
25311cf
Compare
|
Okay, this is ready for review. We're far from done but this is an independent chunk of changes at least. Cc: @mwilck |
Fixed in a separate commit, required more changes across the header file. |
Certain pre-OS driver implementations (i.e. UEFI) may opt to include SSNS records that failed to connect, caused either by a temporary target inaccessibility or an invalid configuration. Such reason is further indicated by TP8029 extended information. This commit adds a flag indicating namespace availability so that clients (nvme-cli) may either decide to skip such record or make another connection attempt. Signed-off-by: Tomas Bzatek <[email protected]>
Indicates that the SSNS record was obtained through discovery. Signed-off-by: Tomas Bzatek <[email protected]>
+ regenerate the sample table outputs. Signed-off-by: Tomas Bzatek <[email protected]>
Two HFIs, four discovery records (only two visible in the table) and some form of multipath. Two SSNS records marked as unavailable due to subnet mismatch. Signed-off-by: Tomas Bzatek <[email protected]>
Code style fixes to satisfy the checkpatch "please, no space before tabs" warnings. Signed-off-by: Tomas Bzatek <[email protected]>
|
Thanks! |
There are significant differences in different vendor implementations of the NVMe Boot Specification and as it turned out not everything is supported by the libnvme NBFT parser.