Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: construct path to config.h manually #760

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

igaw
Copy link
Collaborator

@igaw igaw commented Dec 19, 2023

meson reports:

internal/meson.build:25: DEPRECATION: Project uses feature that was
always broken, and is now deprecated since '1.3.0': str.format: Value
other than strings, integers, bools, options, dictionaries and lists
thereof.

Thus just hardcode the config file path

@igaw igaw marked this pull request as ready for review December 19, 2023 09:48
meson reports:

  internal/meson.build:25: DEPRECATION: Project uses feature that was
  always broken, and is now deprecated since '1.3.0': str.format: Value
  other than strings, integers, bools, options, dictionaries and lists
  thereof.

Thus just hardcode the config file path by using current_build_dir. Note
this changes the path from a relative one to an absolute one.

Signed-off-by: Daniel Wagner <[email protected]>
@igaw
Copy link
Collaborator Author

igaw commented Dec 19, 2023

The absolute path is necessary to build libnvme as subproject in nvme-cli

@igaw igaw merged commit 2e76e27 into linux-nvme:master Dec 19, 2023
14 checks passed
@igaw igaw deleted the build branch December 19, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant