Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build script #746

Merged
merged 4 commits into from
Nov 16, 2023
Merged

update build script #746

merged 4 commits into from
Nov 16, 2023

Conversation

igaw
Copy link
Collaborator

@igaw igaw commented Nov 16, 2023

Several small improvements on the build script for the minimal build with muon.

  • don't rebuild samurai and muon everytime
  • drop the dependency for the wrap feature
  • fix build on older distros (from @ikegami-t )

@igaw igaw merged commit 1ca24e4 into linux-nvme:master Nov 16, 2023
14 checks passed
@igaw igaw deleted the scripts branch November 16, 2023 15:44
igaw and others added 4 commits November 16, 2023 16:45
There is not need to build the build tools everytime. Thus stage the
samurai and muon build into a new top level directory .build-tools and
only build them on demand.

Signed-off-by: Daniel Wagner <[email protected]>
Use the canonical way to set the static build using the command line
argument.

Signed-off-by: Daniel Wagner <[email protected]>
We don't use the wrap feature for building libnvme in the minimal static
configuration. Thus we can drop the library dependency.

Signed-off-by: Daniel Wagner <[email protected]>
On older distros the bootstrap step fails because C99 is not the
default C version. Thus explicitly set it.

Signed-off-by: Tokunori Ikegami <[email protected]>
[dwagner: updated commit message]
Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants