Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme-copy: add cross-namespace copy formats, status codes, ONCS bits #733

Closed
wants to merge 1 commit into from

Conversation

jgu-pure
Copy link
Contributor

@jgu-pure jgu-pure commented Oct 20, 2023

Add support for NVMe TP4130 ("Cross-Namespace Copy"):

  • Add Copy Descriptor Formats 2h and 3h
  • Add new status codes for Copy: Incompatible Namespace or Format, Fast Copy Not Possible, Overlapping I/O Range, and Insufficient Resources
  • Add two new ONCS bits NVMCSA and NVMAFC
  • Add Copy Descriptor Formats Enable (CDFE) to Host Behavior Support
    Data Structure

Copy link

@johnmeneghini johnmeneghini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few small tweaks.

src/nvme/types.h Show resolved Hide resolved
src/nvme/util.c Show resolved Hide resolved
src/nvme/types.h Show resolved Hide resolved
src/nvme/types.h Show resolved Hide resolved
src/nvme/util.c Outdated Show resolved Hide resolved
src/nvme/util.c Outdated Show resolved Hide resolved
src/nvme/util.h Show resolved Hide resolved
src/nvme/util.c Outdated Show resolved Hide resolved
src/nvme/util.c Outdated Show resolved Hide resolved
src/nvme/util.c Outdated Show resolved Hide resolved
src/nvme/util.h Show resolved Hide resolved
Add support for NVMe TP4130 ("Cross-Namespace Copy"):
- Add Copy Descriptor Formats 2h and 3h
- Add new status codes for Copy: Incompatible Namespace or Format, Fast
  Copy Not Possible, Overlapping I/O Range, and Insufficient Resources
- Add two new ONCS bits NVMCSA and NVMAFC
- Add Copy Descriptor Formats Enable (CDFE) to Host Behavior Support
  Data Structure
@igaw
Copy link
Collaborator

igaw commented Nov 2, 2023

I've applied the patch directly after some minor whitespace cleanups. Thanks.

@igaw igaw closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants