make: add checkpatch to Makefile #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically retrieves the checkpatch.pl script from the Linux kernel repo and runs it to check the modified or untracked source files in the current repo. The command can be invoke with: $ make checkpatch Signed-off-by: Martin Belanger <[email protected]>
|
I don't mind something like this to the Makefile, though it might be simpler just to add it to scripts/build.sh (or scripts/check.sh and call this from the Makefile). Though I think it would also be nice if it could support my main use case, which is checking all new commits. That could also be useful as CI step. Just saying :) Do you think this is feasible? |
Ok. I will look into it. But if I'm not mistaking, the code is not 100% "clean". Adding this to the CI will require cleaning all of the code. |
|
@igaw - I found a GitHub action that performs the checkpatch. https://github.com/webispy/checkpatch-action I will try that instead of the changes I made to the Makefile. I'm closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@igaw - Hi Daniel. I noticed that you are asking people to run the
checkpatch.plscript to make sure the code follows the same coding style as the kernel. To make it easier for developers to check their code, I added a new command to theMakefile(i.e.make checkpatch). Hopefully you will find this useful. Otherwise, please ignore.This automatically retrieves the
checkpatch.plscript from the Linux kernel repo and runs it to check the modified or untracked source files in the current repo.The command can be invoked with: