tree: Allocate aligned payloads for namespace scan #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to nvme-cli an alloc helper is needed for a couple of ioctls sent out during tree scan. Signed-off-by: Tomas Bzatek <[email protected]>
libnvme is actually doing some namespace identification during tree scan, leading to stack smash on some systems. Signed-off-by: Tomas Bzatek <[email protected]>
This was referenced Oct 10, 2023
|
Thanks! |
|
IIRC, we have a few more places where we should use the newly introduced |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to linux-nvme/nvme-cli#2051, there are a couple more ioctls made during the tree scan inside of libnvme. Last bits to fix the whole story, hopefully.
Noticed by https://bugs.archlinux.org/task/79760#comment222718