Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Phy Rx Eye Opening Measurement Log #719

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add support for Phy Rx Eye Opening Measurement Log #719

merged 1 commit into from
Sep 20, 2023

Conversation

bpaupore-wdc
Copy link
Contributor

This implements support for TP4119a, adding various fields and functions to enable better handling of the new Physical Receiver Eye Opening Measurement log page.

@bpaupore-wdc
Copy link
Contributor Author

Made an update to add the mi_admin interface for getting the log page, fixing a build failure when integrating these changes with nvme-cli.

@igaw
Copy link
Collaborator

igaw commented Sep 20, 2023

The kdoc build fails:

/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3751: warning: Function parameter or member 'desc' not described in 'nvme_eom_lane_desc'
/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3811: warning: Enum value 'NVME_EOM_EYE_DATA_PRESENT' not described in enum 'nvme_eom_optional_data'
/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3811: warning: Enum value 'NVME_EOM_PRINTABLE_EYE_PRESENT' not described in enum 'nvme_eom_optional_data'
/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3823: warning: Enum value 'NVME_PHY_RX_EOM_NOT_STARTED' not described in enum 'nvme_phy_rx_eom_progress'
/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3823: warning: Enum value 'NVME_PHY_RX_EOM_IN_PROGRESS' not described in enum 'nvme_phy_rx_eom_progress'
/home/wagi/work/libnvme-upstream/.build/../doc/../src/nvme/types.h:3823: warning: Enum value 'NVME_PHY_RX_EOM_COMPLETED' not described in enum 'nvme_phy_rx_eom_progress'
  • Please add a prefix 'types' to commit title, e.g. 'types: Add support Phy...`
  • Drop the generated documentation bits. These changes will be updated when doing the release. This allows easier backporting.

@bpaupore-wdc bpaupore-wdc force-pushed the phy-rx-eom-log branch 2 times, most recently from b22e212 to b950bb9 Compare September 20, 2023 11:50
@bpaupore-wdc
types: Support Phy Rx Eye Opening Measurement Log
6c54728 
This implements support for TP4119a, adding various fields and functions
to enable better handling of the new Physical Receiver Eye Opening
Measurement log page.

Signed-off-by: Brandon Paupore <[email protected]>
@bpaupore-wdc
Copy link
Contributor Author

@igaw Should be fixed up now, didn't realize that the rst files were also automatically generated but it makes sense.

@igaw
Copy link
Collaborator

igaw commented Sep 20, 2023

I haven't found a official released TP on this, only got my hands on drafts. Looks reasonable :) Thanks!

@igaw igaw merged commit e923016 into linux-nvme:master Sep 20, 2023
@bpaupore-wdc
Copy link
Contributor Author

I haven't found a official released TP on this, only got my hands on drafts. Looks reasonable :) Thanks!

Yeah, it took me a while to find the list of latest ratified TPs on the nvme site here. Only way I've found to get there is Read More and View Archive after expanding the base spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-lien-wdc jeff-lien-wdc jeff-lien-wdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpaupore-wdc @igaw @jeff-lien-wdc