Change handles from file-descriptors to 'struct dev_handle' #692
Conversation
Extend the api-types with the following device-handle types: * struct dev_handle * enum nvme_dev_type The 'dev_handle' provides a, possibly opaque, device handle instead of a "fixed" file-descriptor. This allows for non-OS managed device-types such as user-space NVMe-drivers. Additionally, the types allows for library-side dispatch. This is done in preparation for xNVMe, and thereby, support for user-space NVMe driver, io_uring_cmd etc. Signed-off-by: Vikash kumar <[email protected]>
vikash-k5
force-pushed
the
xnvme_plugin_v2
branch
from
fe86b63 to
d2d33d4
Compare
vikash-k5
changed the title
vikash-k5
force-pushed
the
xnvme_plugin_v2
branch
from
d2d33d4 to
7214e2d
Compare
|
This changes the public interface of a huge portion of the libnvme API. I'm not familiar with the "xNVMe" use case you mention, but it seems like it would be good to avoid having to make such widespread changes to users of libnvme. If you need to generalize the notion of a file descriptor, could you add new versions of the functions taking in the new type while leaving the original ones intact? The old functions could call the new functions under the hood, but I think it would be good to keep the existing interface intact as much as possible. |
|
@calebsander These changes are RFC status only and planed for the next major version update of the library. So this will not land in the 1.x branch. We had some offline discussion on these ideas and decided to have some early PR to discuss the API. So don't fear, we wont break 1.x :) For example this PR does only a minimal change necessary to introduce the abstract handle. I think we should go bigger, e.g. see #448 This looks like an excellent topic for the next ALPSS conference :) |
|
Let's close this one. It is libnvme v2 material anyway. |
api: refactor for transport agnostic library backend
Extend the api-types with the following device-handle types:
The 'dev_handle' provides a, possibly opaque, device handle instead of a "fixed" file-descriptor. This allows for non-OS managed device-types such as user-space NVMe-drivers. Additionally, the types allows for library-side dispatch.
This is done in preparation for xNVMe, and thereby, support for
user-space NVMe driver, io_uring_cmd etc.