[WIP] types: Introduce getter macros #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define SHIFT and MASKS value to access values for struct nvme_psd_id members. While at it also cleanup whitespace damages in the documantation to struct nvme_psd_id. Signed-off-by: Daniel Wagner <[email protected]>
igaw
force-pushed
the
define-shift-masks
branch
from
4a4dd33 to
71ca19a
Compare
Signed-off-by: Daniel Wagner <[email protected]>
Define SHIFT and MASKS value to access values for nvme_id_ctrl_cmic. Signed-off-by: Daniel Wagner <[email protected]>
|
FWIW, @hreinecke this is going to be a big effort... I think I work first on the errno return code thing. |
|
After a discussion with Hannes, we decided to postpone this plan. The effort to fixup all definition is a considerable and there is a good chance to introduce a lot of regressions. This is something for v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to work on #148. This will take a while to go through all enums add those missing MASK/SHIFT enums.