Skip to content

Commit

Permalink
Use C99 types for uint32_t
Browse files Browse the repository at this point in the history
<stdint.h> provides `uint32_t`, while `u_int_32` is an unofficial/internal
typedef that glibc happens to provide. This fixes the build on musl.

Bug: https://bugs.gentoo.org/931194

Signed-off-by: Sam James <[email protected]>
  • Loading branch information
thesamesam authored and igaw committed May 6, 2024
1 parent 4382dc0 commit eb99b0c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions src/nvme/base64.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Author: Hannes Reinecke <[email protected]>
*/

#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
Expand All @@ -29,7 +30,7 @@ static const char base64_table[65] =
int base64_encode(const unsigned char *src, int srclen, char *dst)
{
int i, bits = 0;
u_int32_t ac = 0;
uint32_t ac = 0;
char *cp = dst;

for (i = 0; i < srclen; i++) {
Expand Down Expand Up @@ -64,7 +65,7 @@ int base64_encode(const unsigned char *src, int srclen, char *dst)
*/
int base64_decode(const char *src, int srclen, unsigned char *dst)
{
u_int32_t ac = 0;
uint32_t ac = 0;
int i, bits = 0;
unsigned char *bp = dst;

Expand Down
8 changes: 4 additions & 4 deletions src/nvme/linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -1513,10 +1513,10 @@ unsigned char *nvme_import_tls_key(const char *encoded_key, int *key_len,
return NULL;
}
crc = crc32(crc, decoded_key, decoded_len);
key_crc = ((u_int32_t)decoded_key[decoded_len]) |
((u_int32_t)decoded_key[decoded_len + 1] << 8) |
((u_int32_t)decoded_key[decoded_len + 2] << 16) |
((u_int32_t)decoded_key[decoded_len + 3] << 24);
key_crc = ((uint32_t)decoded_key[decoded_len]) |
((uint32_t)decoded_key[decoded_len + 1] << 8) |
((uint32_t)decoded_key[decoded_len + 2] << 16) |
((uint32_t)decoded_key[decoded_len + 3] << 24);
if (key_crc != crc) {
nvme_msg(NULL, LOG_ERR, "CRC mismatch (key %08x, crc %08x)",
key_crc, crc);
Expand Down

0 comments on commit eb99b0c

Please sign in to comment.