Skip to content

Commit

Permalink
j1939spy: remove verbose option
Browse files Browse the repository at this point in the history
If j1939spy is started with the verbose option "-v" or "--verbose", it
will print the error "j1939spy: listening: Success" and exit. Remove
this option altogether.

Fixes: c50b5a3 ("can-j1939: add jspy 'sniffer' program")
  • Loading branch information
marckleinebudde committed Oct 17, 2023
1 parent 51ee436 commit 574df84
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions j1939spy.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ static const char help_msg[] =
"j1939spy: An SAE J1939 spy utility" "\n"
"Usage: j1939spy [OPTION...] [[IFACE:][NAME|SA][,PGN]]" "\n"
"Options:\n"
" -v, --verbose Increase verbosity" "\n"
" -P, --promisc Run in promiscuous mode" "\n"
" (= receive traffic not for this ECU)" "\n"
" -b, --block=SIZE Use a receive buffer of SIZE (default 1024)" "\n"
Expand All @@ -43,8 +42,6 @@ static const char help_msg[] =
#ifdef _GNU_SOURCE
static struct option long_opts[] = {
{ "help", no_argument, NULL, '?', },
{ "verbose", no_argument, NULL, 'v', },

{ "promisc", no_argument, NULL, 'P', },
{ "block", required_argument, NULL, 'b', },
{ "time", optional_argument, NULL, 't', },
Expand All @@ -60,7 +57,6 @@ static const char optstring[] = "vPb:t::?";
* static variables
*/
static struct {
int verbose;
struct sockaddr_can addr;
int promisc;
int time;
Expand Down Expand Up @@ -108,9 +104,6 @@ int main(int argc, char **argv)
/* argument parsing */
while ((opt = getopt_long(argc, argv, optstring, long_opts, NULL)) != -1)
switch (opt) {
case 'v':
++s.verbose;
break;
case 'b':
s.pkt_len = strtoul(optarg, 0, 0);
break;
Expand Down Expand Up @@ -207,8 +200,6 @@ int main(int argc, char **argv)
msg.msg_control = &ctrlmsg;

memset(&tref, 0, sizeof(tref));
if (s.verbose)
err(0, "listening");
while (1) {
/* these settings may be modified by recvmsg() */
iov.iov_len = s.pkt_len;
Expand Down

0 comments on commit 574df84

Please sign in to comment.