Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-21118] - Monitor scope as part of PAT token #11318

Merged

Conversation

ankita-akamai
Copy link
Contributor

Description 📝

A new 'Monitor' scope is enabled within Cloud Manager UI for PAT token creation.

Changes 🔄

  • Added new scope 'Monitor' for PAT token creation.

Target release date 🗓️

2-Dec-2024

Preview 📷

Before After
Before After

How to test 🧪

Verification steps

  1. Login as mock user.
  2. Click on "mock-user" profile tab at the right top.
  3. Go to api-tokens, click on "create a personal access token", you should see "Monitor" listed as one of the scopes with freedom of selecting any/all three types of access.

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai requested a review from a team as a code owner November 25, 2024 11:09
@ankita-akamai ankita-akamai requested review from abailly-akamai and coliu-akamai and removed request for a team November 25, 2024 11:09
@ankita-akamai
Copy link
Contributor Author

ankita-akamai commented Nov 25, 2024

The stated changes in this pr are only from ui perspective and they should be merged in develop along with the apiv4's new scope validation which is in progress..

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing451 Passing2 Skipped119m 9s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock finish event
machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

@kmuddapo
Copy link

The stated changes in this pr are only from ui perspective and they should be merged in develop along with the apiv4's new scope validation which is in progress..

@ankitaakamai Looks like the api changes are already available in alpha. So this comment might not be appropriate. Thanks.

Copy link

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.72%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed 'Monitor' scope appears when creating PAT

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 25, 2024
@ankita-akamai
Copy link
Contributor Author

✅ confirmed 'Monitor' scope appears when creating PAT

@coliu-akamai is any check pending for this branch? I guess we can merge it now..

@coliu-akamai
Copy link
Contributor

ah yep - merging now!

@coliu-akamai coliu-akamai merged commit 8a6d1ca into linode:develop Nov 26, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 26, 2024

Cloud Manager E2E    Run #6884

Run Properties:  status check passed Passed #6884  •  git commit 8a6d1cae4c: upcoming: [DI-21118] - Monitor scope as part of PAT token (#11318)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6884
Run duration 28m 25s
Commit git commit 8a6d1cae4c: upcoming: [DI-21118] - Monitor scope as part of PAT token (#11318)
Committer ankitaakamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 455
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! CloudPulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants