Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8709] – Migrate Autocomplete (and List and ListItem) to ui package #11314

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Migrate Autocomplete (and List and ListItem) to ui package.

Changes πŸ”„

  • Migrate Autocomplete to ui package
  • Migrate List and ListItem to ui package
  • Refactor Autocomplete.stories.tsx to not use linodeFactory (avoid having manager as a dependency of ui package)

Target release date πŸ—“οΈ

12/10/24

How to test πŸ§ͺ

Verification steps

  • All tests should pass
  • There should be no regressions observed in Cloud
  • Autocomplete story in Storybook should be in good shape

As an Author, I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

…date imports and complete refactors accordingly
@dwiley-akamai dwiley-akamai self-assigned this Nov 22, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner November 22, 2024 18:08
@dwiley-akamai dwiley-akamai requested review from hana-akamai and pmakode-akamai and removed request for a team November 22, 2024 18:08
Copy link

Coverage Report: ❌
Base Coverage: 86.83%
Current Coverage: 86.74%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 6 failing tests on test run #3 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
6 Failing448 Passing2 Skipped136m 52s

Details

Failing Tests
SpecTest
❌linode-config.spec.tsEnd-to-End » Clones a config
❌linode-storage.spec.tslinode storage tab » delete disk
❌linode-storage.spec.tslinode storage tab » add a disk
❌rebuild-linode.spec.tsrebuild linode » rebuilds a linode from Community StackScript
❌rebuild-linode.spec.tsrebuild linode » rebuilds a linode from Account StackScript
❌machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants