Adding support --order and --order_by for list operations
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisiorek-akamai
changed the title
--order and --order_by for list operations
|
Looks like unit tests and lint are failing. Tests might need to be updated |
lgarber-akamai
requested changes
Aug 9, 2023
zliang-akamai
approved these changes
Aug 14, 2023
|
there seem to be a large conflict to solve... |
|
Looks like the conflicts are related to the refactors I made to the |
|
Just gonna quickly check that the functionality still remains, I see that we just split up parse_args to be a bit neater so shouldn't impact either PR |
zliang-akamai
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds --order_by and --order to filtering operations.
✔️ How to Test
Tested using command line.
Ex.
linode-cli linodes list --order_by label --order desclinode-cli linodes list --order_by label