Skip to content

Commit

Permalink
remove wait for first consumer storageclass (#288)
Browse files Browse the repository at this point in the history
Co-authored-by: Khaja Omer <[email protected]>
  • Loading branch information
komer3 and komer3 authored Oct 14, 2024
1 parent 0c9e508 commit 6c0a633
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 71 deletions.
18 changes: 0 additions & 18 deletions deploy/kubernetes/base/csi-storageclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,3 @@ metadata:
provisioner: linodebs.csi.linode.com
reclaimPolicy: Retain
allowVolumeExpansion: true
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: linode-block-storage-wait-for-consumer
namespace: kube-system
provisioner: linodebs.csi.linode.com
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: linode-block-storage-wait-for-consumer-retain
namespace: kube-system
provisioner: linodebs.csi.linode.com
reclaimPolicy: Retain
volumeBindingMode: WaitForFirstConsumer
2 changes: 1 addition & 1 deletion docs/topology-aware-provisioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
storageClassName: linode-block-storage-wait-for-consumer
```
> **Important**: The `volumeBindingMode: WaitForFirstConsumer` setting is crucial for topology-aware provisioning. It delays volume binding and creation until a pod using the PVC is created. This allows the system to consider the pod's scheduling requirements and node assignment when selecting the most appropriate storage location, ensuring optimal data locality and performance.
> **Important**: The `volumeBindingMode: WaitForFirstConsumer` setting is crucial for topology-aware provisioning. It delays volume binding and creation until a pod using the PVC is scheduled. This allows the system to consider the pod's scheduling requirements and node assignment when selecting the most appropriate storage location, ensuring optimal data locality and performance.

#### 🖥️ Example Pod

Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,6 @@ metadata:
provisioner: linodebs.csi.linode.com
reclaimPolicy: Retain
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: linode-block-storage-topology-aware-retain
namespace: kube-system
provisioner: linodebs.csi.linode.com
reclaimPolicy: Retain
volumeBindingMode: WaitForFirstConsumer
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: linode-block-storage-topology-aware
namespace: kube-system
provisioner: linodebs.csi.linode.com
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
---
apiVersion: v1
kind: ServiceAccount
metadata:
Expand Down

0 comments on commit 6c0a633

Please sign in to comment.