Avoid using singleton sms manager which holds previous connection state

linkstreet · Dec 10, 2018 · 153cdc0 · 153cdc0
1 parent a20f67d
commit 153cdc0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Providers/SmsServiceProvider.php b/src/Providers/SmsServiceProvider.php
@@ -33,7 +33,7 @@ public function boot()
      */
     public function register()
     {
-        $this->app->singleton('sms', function ($app) {
+        $this->app->bind('sms', function ($app) {
             return new SmsManager($app['config']['sms']);
         });
     }

diff --git a/src/SmsManager.php b/src/SmsManager.php
@@ -112,9 +112,9 @@ public function dispatch(): ResponseInterface
             throw MessageException::notFound();
         }
 
-        $this->connection = $this->connection ?? $this->resolveConnection($this->device);
+        $connection = $this->connection ?? $this->resolveConnection($this->device);
 
-        return $this->getAdapter($this->connection)->send($this->device, $this->message);
+        return $this->getAdapter($connection)->send($this->device, $this->message);
     }
 
     /**