Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all Warnings #59

Closed
wants to merge 2 commits into from
Closed

Conversation

DerekGooding
Copy link

Fixes #58

@Konard
Copy link
Member

Konard commented Dec 1, 2024

@DerekGooding your pull request changes logic, not only fixes warnings. There also new updates available, so please update your pull request, if you want it to be merged.

I also don't see why we need lower case id instead of Id alias (as it agains C# coding style tradition).

How did you found out our project?

@DerekGooding
Copy link
Author

This is a year old. Don't revive things. Just move on.

This is a public repo with a Help Wanted issue label. People search for those to help contribute to open source projects.

You let this project sit for what? Feb to Nov? Then you worked on it for a month without seeing this PR? Super unprofessional.

@Konard
Copy link
Member

Konard commented Dec 1, 2024

Sorry, but I'm only human after all :)
I cannot to be everywhere at the same time.
I wrote you as soon as I noticed your pull request.

Thank you for your efforts anyway. It is nice to know that people are willing to help.

If you like the project, may be you will also like the new one, that is based on this one: https://github.com/link-foundation/link-cli

I'm not sure why I shouldn't revive things. The idea of that project exists for years, and it continues to evolve. For me I see it as ok. At the moment it is non commercial project. And it evolves with its own pace.

I think contributions like one you did are not aging so fast to just move on.

@Konard
Copy link
Member

Konard commented Dec 1, 2024

By the way, we can keep structure to be named Id or even IdMarker and let the alias be id as a compromise solution. Lower case id should be faster to type.

Though this way of constructing nested links structures was an experimentation, I may turn out to be useful in the future.

Anyway, I'm sorry that my actions made you feel bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all warnings
2 participants