Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate path for CI reports #1334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Create separate path for CI reports #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/UnitTests-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
git fetch upstream
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Run Unit Tests with Code Coverage
- name: Run Unit Tests & Code Coverage
run: ./gradlew -x :internal:venice-avro-compatibility-test:test ${{ inputs.arg }}
- name: Package Build Artifacts
if: success() || failure()
Expand All @@ -52,9 +52,11 @@ jobs:
- name: Publish Test Report
env:
NODE_OPTIONS: "--max_old_space_size=4096"
uses: mikepenz/action-junit-report@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this has to be right after

Run Unit Tests & Code Coverage

If we want to run it on failure only

if: always() # always run even if the previous step fails
uses: mikepenz/action-junit-report@v5
continue-on-error: true # Make this step always pass
if: failure() # run if the previous step fails
with:
check_name: ${{ inputs.artifact_suffix }}-jdk${{ matrix.jdk }} Report
report_paths: '**/build/test-results/test/TEST-*.xml'
- name: Upload Build Artifacts
if: success() || failure()
Expand Down