[vpj][controller] Do not optimize backup version deletion for TTL repush #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacAttack
previously approved these changes
Nov 20, 2024
majisourav99
force-pushed
the
ttlRepush
branch
from
8e09d5d to
bc6967c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not optimize backup version deletion for TTL repush
Today Venice deletes the repush source version as it is exactly same as repushed version immediately after the push. But for TTL repush since it differs from the source version this assumption is not correct. This PR prevents early deletion of TTL repush version and treats it as regular push.
Also it creates a new pushID for ttl repush which would help tracking regular repush vs ttl repush.
How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?