[server] Consumer Refactor (Part 1) #1318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nTask` into `StorePartitionDataReceiver`. 🧹
…ngestionTask` into `StorePartitionDataReceiver`. 🧹
…ght before `waitUntilValueSchemaAvailable()` from `StoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…orePartitionDataReceiver`. 🧹
…rom `StoreIngestionTask` / `LeaderFollowerStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…) from `LeaderFollowerStoreIngestionTask` / `ActiveActiveStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…FollowerStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…rStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
… from `LeaderFollowerStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…werStoreIngestionTask` / `ActiveActiveStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…tionTask` into `StorePartitionDataReceiver`. 🧹
…tionTask` into `StorePartitionDataReceiver`. 🧹
…Task` / `ActiveActiveStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
…ionTask` / `ActiveActiveStoreIngestionTask` into `StorePartitionDataReceiver`. 🧹
KaiSernLim
force-pushed
the
consumer-refactor
branch
from
9bc3128 to
a39d5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
StoreIngestionTaskfile is getting too large and should be refactored.One thing we can do is move all consumer-only functions and member variables out of
StoreIngestionTaskinto a consumer class such asStorePartitionDataReceiver. The final result can be seen here.How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?