Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turn on werror for neo4j-dao #60

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix: turn on werror for neo4j-dao #60

merged 1 commit into from
Dec 3, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Dec 3, 2020 •
edited
Loading

I also got rid of the tuple library while I was here, easier than trying to get the generics right :)

#29

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

fix: turn on werror for neo4j-dao
b1c6525 
I also got rid of the tuple library while I was here, easiler than trying to get the generics right :)
@jplaisted jplaisted requested a review from woodyzhou December 3, 2020 22:49
woodyzhou
woodyzhou approved these changes Dec 3, 2020
View reviewed changes
Copy link

@woodyzhou woodyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jplaisted jplaisted merged commit a975079 into linkedin:werror Dec 3, 2020
@jplaisted jplaisted deleted the werror5 branch December 3, 2020 23:57
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Dec 4, 2020
fix: turn on werror for neo4j-dao (linkedin#60)
100bd02 
I also got rid of the tuple library while I was here, easiler than trying to get the generics right :)
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Jan 14, 2021
fix: turn on werror for neo4j-dao (linkedin#60)
c5faa27 
I also got rid of the tuple library while I was here, easiler than trying to get the generics right :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodyzhou woodyzhou woodyzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplaisted @woodyzhou