cleanup: Add no-internalModels-flag variants to methods used by GMS's #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
============================================
- Coverage 68.02% 67.87% -0.16%
Complexity 1635 1635
============================================
Files 143 143
Lines 6252 6266 +14
Branches 682 682
============================================
Hits 4253 4253
- Misses 1709 1723 +14
Partials 290 290 ☔ View full report in Codecov by Sentry. |
yangyangv2
reviewed
Nov 13, 2024
| @Nonnull | ||
| protected Map<URN, VALUE> getInternal(@Nonnull Collection<URN> urns, | ||
| @Nonnull Set<Class<? extends RecordTemplate>> aspectClasses) { | ||
| final boolean isInternalModelsEnabled = getResourceLix().testGetAll(_urnClass.getSimpleName()); |
There was a problem hiding this comment.
the getResourceList().testGetAll() gives low granular lix control on getAll method. Putting it inside the getInternal() will lose this granularity.
yangyangv2
reviewed
Nov 13, 2024
| @Nonnull | ||
| protected Map<URN, VALUE> getInternalNonEmpty(@Nonnull Collection<URN> urns, | ||
| @Nonnull Set<Class<? extends RecordTemplate>> aspectClasses) { | ||
| final boolean isInternalModelsEnabled = getResourceLix().testGetAll(_urnClass.getSimpleName()); |
There was a problem hiding this comment.
same here, unless only getAll is calling this method. But there's no restriction for future cases
yangyangv2
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add no-flag variants to methods so that consumer GMS's don't need to call "lix logic", which is confusing since there is no Lix active any more.
Non-TMS Codesearch: https://jarvis.corp.linkedin.com/codesearch/results/?query=mp%3A*-gms%20getResourceLix
TMS Codesearch: https://jarvis.corp.linkedin.com/codesearch/results?query=mp%3Ametadata-store+getResourceLix¤t=1&nresults=10
Testing Done
n/a
Checklist