Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable werror for dao-api. #33

Merged
merged 1 commit into from
Nov 20, 2020
Merged

fix: enable werror for dao-api. #33

merged 1 commit into from
Nov 20, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Nov 4, 2020 •
edited
Loading

#29

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jplaisted
Copy link
Contributor Author

ping

camelliazhang
camelliazhang reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@camelliazhang camelliazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

build.gradle Show resolved Hide resolved
@jplaisted
Copy link
Contributor Author

Also, since this is a breaking change, and the others will be too, how do we feel about adding them to a separate branch, and then once they're all in merging to master without review? i.e. review small PRs to the other branch, then we can have one big breaking change all at once that was "already reviewed" in chunks?

@jplaisted jplaisted force-pushed the werror1 branch 2 times, most recently from 864d002 to 35983bd Compare November 20, 2020 19:00
@jplaisted jplaisted changed the base branch from master to werror November 20, 2020 19:38
@jplaisted jplaisted merged commit b4f46ad into linkedin:werror Nov 20, 2020
@jplaisted jplaisted deleted the werror1 branch November 20, 2020 19:38
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Dec 4, 2020
fix: enable werror for dao-api. (linkedin#33)
d1d73ee
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Jan 14, 2021
fix: enable werror for dao-api. (linkedin#33)
9771a6f
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Jan 14, 2021
fix: enable werror for dao-api. (linkedin#33)
59bad03
jplaisted pushed a commit to jplaisted/datahub-gma that referenced this pull request Jan 14, 2021
fix: enable werror for dao-api. (linkedin#33)
4dfc215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelliazhang camelliazhang camelliazhang left review comments

@keremsahin1 keremsahin1 keremsahin1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplaisted @keremsahin1 @camelliazhang